osuosl / streamwebs

Streamwebs.org website
http://streamwebs.readthedocs.io/
4 stars 1 forks source link

Unable to register new user with New Org. #596

Closed hertelc closed 6 years ago

hertelc commented 6 years ago

Tested on staging.

I had attempted to create a user with an email that was already in the system. I was given an error that an email address already existed.

Later on, I tried Registering a new school and the screen cleared other than name and email, but I did not see any other messages. I'm assuming this is also a duplicate email error?

I don't have privledges atm to check if a duplicate email exists. I was on staging and trying to use kolstadc@gmail.com.

hertelc commented 6 years ago

Well.... maybe it just doesn't give me a submission successful message?? I tried with an email that I know for sure is not in the system yet and saw the same behavior.

NathanTan commented 6 years ago

The current problem is that when making a new organization, the organization name does not get filled out in the profile_form (The UserProfileForm), thus the profile_form is invalid and the process halts right there. So if the school_form is valid, then the profile_form should probably use the organization information from the school_form. This happens in the 'def register' function in general.py

CarvellWakeman commented 6 years ago

If you register a new school but don't do everything correctly, the page will come back with errors but the new org section will not expand. Opening it will reveal the errors that need fixing. Perhaps this is related.

hertelc commented 6 years ago

I just tried this again and re-expanded the "New" org page and I didn't see any errors there.

CarvellWakeman commented 6 years ago

Found out it's because when a new school is made, the school select field is not filled out. This results in the page being invalid. There is no error because the autocomplete field is custom and the validation doesn't know where to put the errors. When the register page server validation is done, the errors will display correctly.

Working on fixing.

hertelc commented 6 years ago

Confirmed this looks good. Will do deeper testing on 1/2, but was able to have a new org and user join as expected on the Dev site.