osuosl / streamwebs

Streamwebs.org website
http://streamwebs.readthedocs.io/
4 stars 1 forks source link

Page for New Org Approval #621

Closed hertelc closed 6 years ago

hertelc commented 6 years ago

Is there a way for the super admin to see what orgs need approval without using the email/link? Not sure the pending schools will be included in the View Schools page or not.

CarvellWakeman commented 6 years ago

Pending schools are not included in the schools page. There is also no existing way to view org requests. But it should be fairly easy to do if you put up an issue for it.

hertelc commented 6 years ago

Actually, I did see a school in the list that was pending... I didn't know it was until I did some more digging. I don't think that's an issue though. An approve org page would be good. I'll log it. Thanks!

On Jan 6, 2018 1:29 PM, Zach Lerew notifications@github.com wrote:

Pending schools are not included in the schools page. There is also no existing way to view org requests. But it should be fairly easy to do if you put up an issue for it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/osuosl/streamwebs/issues/621#issuecomment-355778858, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ATYck5pcUkABw8-WWtNY-7QNtlT0nfifks5tH-WhgaJpZM4RVbqg.

hertelc commented 6 years ago

I'm just going to change this to a feature request from a question.

CarvellWakeman commented 6 years ago

@hertelc Mark and I discussed this page and how it can tie into the user story for editor replacement.

Ex: An editor leaves an organization or is removed from one, and were the only editor in their organization. A new editor comes in to replace them but has no way to access the account. Currently, the new editor can register for an account and the old editor can approve them. In the scenario where the old editor cannot or will not do that, the super admin will need to step in. This new org approval page can be modified to make this problem easier to solve for super admins.

This "unapproved accounts" page has a first section for new organization requests and provide links to the new org request page.

The second section is for unapproved users, and would display all users in the system who are currently unapproved. It would include links to the user's school's manage accounts page, as well as quick links to deny the user.

If this sounds like a good idea, we can get a mockup made and go from there!

hertelc commented 6 years ago

YES! We weren't sure how the organizations who don't have anyone responding to approve accounts was going to be handled. This answers that too, so lets do it!

CarvellWakeman commented 6 years ago

Done in feat/approval_page branch. PR #628

hertelc commented 6 years ago

@CarvellWakeman this looks good. I'm going to leave the issue open until we test it on staging. I think you can merge into the develop branch now??

CarvellWakeman commented 6 years ago

Merged into develop. Closing this issue.