search

osuosl / streamwebs

Streamwebs.org website
http://streamwebs.readthedocs.io/
4 stars 1 forks source link

Approve Page: New school/User; only User is approved #635

Closed hertelc closed 6 years ago

hertelc commented 6 years ago

When testing with creating an account with a new school/user it appears that the user is approved but the school is not... I viewed and approved the request from the approval page but when I login as that new user, it says my school is not yet approved.

Tested using Win8.1 and Firefox.

Steps to reproduce:

  1. Create an account with a new user and new school. Submit.
  2. Login as Admin and navigate to the "Approve Accounts" page.
  3. Click "View Request" for the new org and Approve.
  4. Logout and login as that new user.
  5. Click on "Manage Accounts".

Note, I'm working on the dev instance and emails don't seem to be working. I'm working around that and maybe that is not submitting something correctly.

http://streamwebs-dev.osuosl.org:8000/

CarvellWakeman commented 6 years ago

To note: emails are disabled via a global flag which is set to false on local builds and the dev site. Not sure if @ramereth has been setting it to true for staging or not. I'll check to see if it's involved, but it shouldn't be.

CarvellWakeman commented 6 years ago

@hertelc I Figured out why that bug happened. The emails flag that is supposed to be set to false in the global settings.py file did not exist. The issue was that the settings.py file does not automatically update when the branch is pulled, is has to be created from the settings.py.dist file. I tested the issue with and without the flag, and it only occurred without the flag.

I pushed to the branch to make sure the settings.py.dist had that flag, I think it didn't for whatever reason?

I'll leave dev on the approval_page branch if you wanted to test it again later.

hertelc commented 6 years ago

Looks good on Dev. Closing issue.