search

osuosl / timesync-frontend-flask

Flask front-end client for TimeSync
Other
0 stars 2 forks source link

Use cached project and activity data for create/edit/view times #135

Closed aaroncohen73 closed 8 years ago

aaroncohen73 commented 8 years ago

Fixes #126

Changes in this PR.

  1. Run nosetests
  2. Make sure that TIMESYNC_URL is set to http://timesync-staging.osuosl.org/v0 in config.py
  3. Run the app and log in as admin/timesync-staging
  4. Go to /times/create and see that activities is now a multiselect box
  5. Go to /times and see that projects and activities are both multiselect boxes

    Expected Output.

14:30 $ nosetests
................................................................................................................................
----------------------------------------------------------------------
Ran 128 tests in 10.569s

OK

@osuosl/devs

subnomo commented 8 years ago

Definitely going to need CSS later to improve usability, but it does what it should. :+1:

pop commented 8 years ago

lgtm +1 good work, this is really nice.

Is there a reason we're not making users a multi-iselect box too?

aaroncohen73 commented 8 years ago

@ElijahCaine I don't think there was a reason not to do that. I've added it in just now, so could you quickly look it over before it gets merged?

pop commented 8 years ago

@aaroncohen73 That's a good change imo, if for no other reason than consistency. +1 from me.