osuresearch / mrm-preset-osuresearch

OSU Research preset and tasks for Mrm
MIT License
0 stars 0 forks source link

Backport reconfigurations from RUI #2

Open McManning opened 1 year ago

McManning commented 1 year ago

I made some adjustments to templates in RUI that should probably be backported into here.

Few of the changes off the top of my head:

McManning commented 1 year ago

Should probably fix the logo placeholder at the very least in Storybook - default it to the project name:

image

McManning commented 1 year ago

Also want the importOrder rules from RUI for prettier:

    "importOrder": [
      "^@osuresearch/ui(.*)$",
      "^[~/]",
      "^[./]"
    ],
    "importOrderSeparation": true,
    "importOrderSortSpecifiers": true

with the addition in .eslintrc#extends: simple-import-sort and removing import order errors because why make it an error when we can autocorrect

Will need a more general variation of the above. I do use an alias in tsconfig for files relative to package root (e.g. ~/components/Button) but I don't know if I want to suggest that as common practice for other developers.

Will need npm i eslint-plugin-simple-import-sort

McManning commented 1 year ago

Also semantic release CI needs updating to support legacy branches and the like