Feature: created a `DateRangeField` component following the specs in the ticket (Closes #70)

osuresearch / ui

Ohio State Research UI

https://osuresearch.github.io/ui/main

MIT License

6 stars 3 forks source link

Feature: created a `DateRangeField` component following the specs in the ticket (Closes #70) #75

Closed helloLilyX closed 1 year ago

helloLilyX commented 1 year ago

Imported it in the component/index.tsx and add it to the uncontrolled and RHF7 form examples

helloLilyX commented 1 year ago

Note: changed FormFieldBase value from (string | undefined)[] to (string | undefined)[] | undefined as we discussed

helloLilyX commented 1 year ago

Noticed bugs:

Focus wouldn't move to the next segment after typing into the current one in the end date field
Segments in the disabled story example(with isDisable={true} prop) still have segment.isEditable=true

helloLilyX commented 1 year ago

Accessibility concern: focus isn't sent to the month segment after click on the input field whose value is Anytime

McManning commented 1 year ago

This PR became bit of a mess when I swapped it to the dev branch to pull into. I'm just going to cherry pick the DateRangeField component files out and merge those in manually.

McManning commented 1 year ago

Also of note, there's a handful of accessibility issues with this. E.g. you can't tab to the end date.

McManning commented 1 year ago

Cherry picked changes into the dev branch. Closing this out.