osuresearch / ui

Ohio State Research UI
https://osuresearch.github.io/ui/main
MIT License
6 stars 3 forks source link

The link to the Ohio State home page in the banner displays “OSU.EDU” but a screen reader announces it as “The Ohio State University” #87

Closed McManning closed 1 year ago

McManning commented 1 year ago

The link to the Ohio State home page in the banner displays “OSU.EDU” but a screen reader announces it as “The Ohio State University”. Logos especially should announce exactly as how they are read if made of text.

WCAG 2.5.3 Label in Name • Recommendation: Since it is a background image, remove the link text as it both inaccurate and redundant. Change the title attribute to read, “OSU.EDU, home”. • Priority: Moderate

helloLilyX commented 1 year ago

Do I ignore Anchors must have content and the content must be accessible by a screen reader.eslint[jsx-a11y/anchor-has-content](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/anchor-has-content.md)?

McManning commented 1 year ago

I think let's try swapping it around, instead of using title let's just have the anchor text be "OSU.EDU, home". That should be read off by SR's, even if it's visibility hidden from sighted users.

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 4.9.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: