search

oswaldoacauan / ghostium

A Ghost theme focused on content based on Medium design/ux.
https://ghost.org/?lmref=our-LA
MIT License
1.27k stars 382 forks source link

Comment Links on Homepage #13

Closed howardchiang92 closed 10 years ago

howardchiang92 commented 10 years ago

Clicking on "X Comments" at the end of an excerpt on the homepage does not lead you to the disqus portion of the actual post.

This is an issue with ghostium / partials / post / list.hbs, specifically the footer line:

a href="{{url}}#disqus_thread" data-disqus-identifier="{{id}}">

I apologize for not having any experience with this, so I don't know if I've presented everything as clearly as possible here.

oswaldoacauan commented 10 years ago

It's clear enough ;) Wich version of Ghostium are you using? You can check that on ghostium/package.json

yosz commented 10 years ago

Before the fix for backward/forward - the link didn't work as far as I remember. Now it works, but when clicked #disqus_thread does not appear in url, so page doesn't scroll to disqus thread.

howardchiang92 commented 10 years ago

I am using 1.1.1. It doesn't seem to work on my blog or ghostium.oswaldoacauan.com

yosz, I'm not sure which fix you are referring to.

yosz commented 10 years ago

I was referring to commit https://github.com/oswaldoacauan/ghostium/commit/0212b4370b9e02b0cc234c28b300f0c5b12dff2d

I've built ghostium myself and it worked (but didn't scroll to disqus thread)