Update all dependencies to latest; various tweaks in support of updates - Githubissues

oswaldoacauan / ghostium

A Ghost theme focused on content based on Medium design/ux.

https://ghost.org/?lmref=our-LA

MIT License

1.27k stars 382 forks source link

Update all dependencies to latest; various tweaks in support of updates #163

Closed joshuahiggins closed 7 years ago

joshuahiggins commented 8 years ago

This pull request is to bring Ghostium's dependencies up to date.

The following packages are updated:

Ruby: 2.0.0 -> 2.2.1
Font Awesome: 4.1.0 -> 4.5.0
jQuery: 2.0.3 -> 2.2.0
jQuery PJAX: ??? (master) -> 1.9.6
modernizr: 2.6.2 -> 2.8.3
PACE: 0.5.1 -> 1.0.2
Prism: ??? (gh-pages) -> 1.3.0
SASS: 3.2.11 -> 3.4.21
csscss: 1.3.2 -> 1.3.3
All NPM dependencies to latest

Also, made the following tweaks in support of updating dependencies:

Updated pageUrl to page_url (Ghost will deprecate in v0.6)
Fixed an error a jQuery selector was throwing
Depend on blocking JS packages from CDN (w/ DNS prefetch)
Extended Prism to support a few more packages:
- Docker
- Git
- HAML
- Markdown
- Swift
- Typescript
- YAML
Replaced .rvmrc with .ruby-version (cross compatible with other version managers)

joshuahiggins commented 8 years ago

Hm, I didn't test all the way back to Node 0.10... It's likely some of the Grunt dependencies don't support that early of a Node version.

As a side note, I did some before and after tests on the performance improvements from the changes made in this PR.

Before: 10 requests, 196KB, DOM ready 1.06s, loaded 1.36s
After: 12 requests, 184KB, DOM ready 431ms, loaded 509ms

Offloading blocking JS in the head to a CDN and completely offloading fonts to a CDN made the most notable impacts.

Considering this is a theme for a blog, there's going to be a lot of concurrent requests already being made to the server, so it makes sense to offload requests wherever it makes sense to increase page load.