search

osx-cross / homebrew-avr

Homebrew AVR Toolchain
BSD 2-Clause "Simplified" License
394 stars 79 forks source link

Fix brew test by avoiding to use ENV.clear in formulas #290

Closed jmechnich closed 1 year ago

jmechnich commented 1 year ago

Following advice by the homebrew core developers, clearing the shell environment is not a great idea for several reasons. In fact, it is not done in any of the other core formulas. I have checked all gcc versions locally on macOS Ventura on ARM, and apparently only CPATH needs to be unset.

jmechnich commented 1 year ago

Should I split this up in individual commits per formula? Or does it even have to be separated into multiple PRs?

ladislas commented 1 year ago

let me review the workflows first, I haven't updated them in a while.

I'll let you know when you can rebase.

ladislas commented 1 year ago

@jmechnich I've updated the CI

can you rebase and split this PR for each formula modified?

it will also make things faster

jmechnich commented 1 year ago

@jmechnich I've updated the CI

can you rebase and split this PR for each formula modified?

it will also make things faster

just to clarify: split into individual PRs, or just the commits?

ladislas commented 1 year ago

individual PRs

jmechnich commented 1 year ago

Ok, maybe I should close this one first then :sweat_smile: