search

osxfuse / filesystems

Example file systems
379 stars 94 forks source link

Updating filesystems-objc #6

Closed drichardson closed 12 years ago

drichardson commented 12 years ago

Various changes to filesystems-objc to bring it up to date. Changes include:

bfleischer commented 12 years ago

Doug, thank you for your work!

As expressed in my recent post regarding your changes, I'm not a big fan of having all projects in one workspace. I don't see the benefit of having the additional workspace. This might be confusing, if not all file systems are in the workspace. Therefore I dropped commit 118df0e0ea199afaa981917ee3ae9e00ff73324d.

In commit 1a8eb669ccc33d5477fb1c4fbd191265b0ae4847 you seem to check twice that error is not NULL. I removed the double check and merged the commit with the previous one.

Since commit 4868cc0cc994f0e1b4478d554b5f2aeb401aef62 is a fix for commit 813a66af12b45b2afaa5bc71c0f13aa027479696 and I had to rebase anyway, I merged them into one, too.

In addition to that I reworded most commit messages to add the name of the project that is changed and to add some more details. This makes finding a specific commit easier.

Code-wise commits d844610a590cc37e2716f955c30b3359d0469359 to b0f2eaae86b24451f2c8d1c42367bd040eaeb74c are identical to your changes (without the above mentioned double check).

Again, thanks!

drichardson commented 12 years ago

On Jan 19, 2012, at 6:43 PM, Benjamin Fleischer wrote:

In commit 1a8eb669ccc33d5477fb1c4fbd191265b0ae4847 you seem to check twice that error is not NULL. I removed the double check and merged the commit with the previous one.

Since commit 4868cc0cc994f0e1b4478d554b5f2aeb401aef62 is a fix for commit 813a66af12b45b2afaa5bc71c0f13aa027479696 and I had to rebase anyway, I merged them into one, too.

Yeah, sorry about that, I should have fixed the commit instead of patching it later.