search

osxmidi / LinVst

Linux Windows vst wrapper/bridge
GNU General Public License v3.0
674 stars 41 forks source link

Feature Request - Do not require root permissions #112

Closed ismaelgv closed 4 years ago

ismaelgv commented 5 years ago

I think that not requiring root permissions would be a very interesting addition to this project, for both development and final end-user usage.

I am still trying to understand the code flow but I have noticed that /usr/bin/lin-vst* are hardcoded in remotevstclient.cpp. The logic to obtain the correct path for LinVstName could be included in another place (path.cpp for example) in order to refactor and simplify remotevstclient.cpp. Finally, I think that execlp() already looks for files includes in $PATH as far as it is described here.

This way LinVst can be used without root permissions but maybe I am missing some reason here that you could clarify.

If you are interested, I would like to contribute to this project and try to handle this issue.

osxmidi commented 5 years ago

I think I needed to hardcode the path because of how Wine starts the server.

The execlp() already looks for files includes in $PATH might work for linux things but I couldn't get it working with Wine.

ismaelgv commented 4 years ago

First, sorry for the late response. I would like to take a deeper look at this issue if this is OK for you. I don't know if I will find a solution but I will do my best.

In addition, I was wondering if you are interested in refactoring the code related to this part, that is mostly macro-based. In any case, I would do that in a separate PR.

osxmidi commented 4 years ago

If you come up with anything then I'll look at it and test it out.

osxmidi commented 4 years ago

I'll test it out soon.