search

osxmidi / LinVst

Linux Windows vst wrapper/bridge
GNU General Public License v3.0
682 stars 41 forks source link

[WIP] Refactor macros #117

Closed ismaelgv closed 5 years ago

ismaelgv commented 5 years ago

As I commented in #112, I have started to refactor the code related to path search and generation in remotevstclient.cpp. The idea is to reduce the use of macros to improve readability, code completion from IDEs, etc. Later, I will try to handle execlp() calls using enviromental variables in wine, but I wanted to separate both changes to ease reviewing and testing.

In this PR, I have added some functionality to paths.h to generate the paths. Right now, it will handle the generation based on the basename, a suffix and the extension. It will consider #ifdef EMBED to add st to the name of the file.

The parent directory is still hardcoded to /usr/bin, but extracted to that function. The idea is to continue developing this solution and insert the logic to read from enviromental variables (or other places) there.

I just partially tested this refactor, and since it has been very large, it would be nice to receive some feedback of the changes.

osxmidi commented 5 years ago

Some good ideas that I might use in future releases.

ismaelgv commented 5 years ago

I am happy to contribute to this project, thank you for your effort.

ismaelgv commented 4 years ago

It seems that this PR was reverted, did it cause any problem?

Just to know for future contribution in the project.