Closed keybreak closed 3 years ago
I can't replicate those problems, but for the time being I'm going back to LinVst 3.0.
That's weird though, if i can provide any more useful information please hit me up:
One i could probably think of is that i route all my sound through jack and use RME Fireface UCX Also that happens for some time (3-4 seconds), just before they crash, but GUI is still up and there is clearly no sound going out
but for the time being I'm going back to LinVst 3.0
Thx, i'll test it out soon to see if it reverted correctly, just in case ;)
Ok so i've tested current master, all of that rolled back correctly and doesn't happen any more: https://github.com/osxmidi/LinVst/issues/163 https://github.com/osxmidi/LinVst/issues/164 https://github.com/osxmidi/LinVst/issues/165 https://github.com/osxmidi/LinVst/issues/166
btw that case is affected on current master i assume, might wanna mention it until new solution will emerge: https://github.com/osxmidi/LinVst/issues/161
Ok so i've tested current master, all of that rolled back correctly and doesn't happen any more:
163 #164 #165 #166
btw that case is affected on current master i assume, might wanna mention it until new solution will emerge:
161
Thanks for reminding me of the samplerate bug.
I've updated the code and binaries.
And now revert it back, please :rofl: It's exactly what caused this two: https://github.com/osxmidi/LinVst/issues/163 https://github.com/osxmidi/LinVst/issues/165
Just tested
P.S. btw don't rush with packing binaries, just ask me to test first, so we can be sure :smiley:
And now revert it back, please It's exactly what caused this two:
163
165
Just tested
P.S. btw don't rush with packing binaries, just ask me to test first, so we can be sure
Wow, I didn't think it would do that, I'll need to look into it.
I made some changes to the code, see how it is now.
Yes, looks like you fixed it! btw i just wonder why you have decided to remove:
m_plugin->dispatcher(m_plugin, effSetBlockSize, 0, 1024, NULL, 0);
m_plugin->dispatcher(m_plugin, effSetSampleRate, 0, 0, NULL, (float)44100);
in the first place?
It looks logical to use bufferSize and sampleRate instead of fixed values, as you did on last commit :+1:
I'll keep testing to see if everything else is fine :upside_down_face:
Maybe meanwhile we should ask @brandflake11 to test current master code, and check if https://github.com/osxmidi/LinVst/issues/161 haven't been affected with update, since i couldn't personally repeat his problem (you as well i believe?)
Yes, looks like you fixed it! btw i just wonder why you have decided to remove:
m_plugin->dispatcher(m_plugin, effSetBlockSize, 0, 1024, NULL, 0); m_plugin->dispatcher(m_plugin, effSetSampleRate, 0, 0, NULL, (float)44100);
in the first place?
It looks logical to use bufferSize and sampleRate instead of fixed values, as you did on last commit
I'll keep testing to see if everything else is fine
Maybe meanwhile we should ask @brandflake11 to test current master code, and check if #161 haven't been affected with update, since i couldn't personally repeat his problem (you as well i believe?)
I removed the lines because I didn't think they were needed, but it looks like some plugins do need them.
I can test the Renoise samplerate bug because it happens on one of my systems and it seems to be ok with the new changes.
No sound, happens on v3.1 / master - doesn't happen with 2.8 / 3.0
Tested with Renoise v3.2.2, under same environments / conditions
Enviroments
VSTi
u-he ACE v1.4.0.3898 x64
stdout/stderr (removed some duplicated entries)
``` DSSI VST plugin server v0.986 Copyright (c) 2012-2013 Filipe Coelho Copyright (c) 2010-2011 Kristian Amlie Copyright (c) 2004-2006 Chris Cannam LinVst version 3.1.0 Loading /home/x133/.PlayOnLinux/wineprefix/VST/drive_c/VST/VSTi/u-he/ACE/ACE(x64).dll C:\users\x133\Desktop\/ACE.log no deskTopFile found 00f4:fixme:ntdll:NtQuerySystemInformation info_class SYSTEM_PERFORMANCE_INFORMATION Renoise LOG> VstPlugs: Analyzing VST plugin 'u-he: ACE(x64)', Unique ID:1633895765, Version:2400 Renoise LOG> VstPlugs: Instantiate OK Renoise LOG> VstWindow: Creating a new X11Window... Renoise LOG> VstWindow: Setting X11Window properties... Renoise LOG> VstWindow: Give the plug access to the X11Window... server 2 2 16 No load font, arrrgh! Renoise LOG> VstWindow: Query the X11Window child... Renoise LOG> VstWindow: Unexpected XGetWindowProperty ptr value: expected a userSize 32 with two entries, got userSize: 0 with 0 entries... Renoise LOG> VstWindow: Child window has no '_XEventProc' property set... Renoise LOG> VstWindow: Setting new Windowsize 1326, 754 Renoise LOG> VstWindow: Mapping the window... Renoise LOG> VstWindow: Setting new Windowsize 1326, 754 No load font, arrrgh! Renoise LOG> VstWindow: Closing the Editor... Renoise LOG> VstWindow: Editor was closed Renoise LOG> VstWindow: Creating a new X11Window... Renoise LOG> VstWindow: Setting X11Window properties... Renoise LOG> VstWindow: Give the plug access to the X11Window... server 2 2 16 server 2 2 16 No load font, arrrgh! Renoise LOG> VstWindow: Query the X11Window child... Renoise LOG> VstWindow: Unexpected XGetWindowProperty ptr value: expected a userSize 32 with two entries, got userSize: 0 with 0 entries... Renoise LOG> VstWindow: Child window has no '_XEventProc' property set... Renoise LOG> VstWindow: Setting new Windowsize 1326, 754 Renoise LOG> VstWindow: Mapping the window... Renoise LOG> VstWindow: Setting new Windowsize 1326, 754 No load font, arrrgh! Renoise LOG> VstWindow: Closing the Editor... Renoise LOG> VstWindow: Editor was closed Renoise LOG> VstWindow: Creating a new X11Window... Renoise LOG> VstWindow: Setting X11Window properties... Renoise LOG> VstWindow: Give the plug access to the X11Window... server 2 2 16 No load font, arrrgh! Renoise LOG> VstWindow: Query the X11Window child... Renoise LOG> VstWindow: Unexpected XGetWindowProperty ptr value: expected a userSize 32 with two entries, got userSize: 0 with 0 entries... Renoise LOG> VstWindow: Child window has no '_XEventProc' property set... Renoise LOG> VstWindow: Setting new Windowsize 1326, 754 Renoise LOG> VstWindow: Mapping the window... Renoise LOG> VstWindow: Setting new Windowsize 1326, 754 No load font, arrrgh! Renoise LOG> VstPlugs: Releasing /home/x133/.vst/ACE(x64).so (closing the VST editor)... Renoise LOG> VstWindow: Closing the Editor... Renoise LOG> VstWindow: Editor was closed ```u-he Diva v1.4.1.4078 x64 (no sound before crash)
stdout/stderr (removed some duplicated entries)
``` DSSI VST plugin server v0.986 Copyright (c) 2012-2013 Filipe Coelho Copyright (c) 2010-2011 Kristian Amlie Copyright (c) 2004-2006 Chris Cannam LinVst version 3.1.0 Loading /home/x133/.PlayOnLinux/wineprefix/VST/drive_c/VST/VSTi/u-he/Diva/Diva(x64).dll C:\users\x133\Desktop\/Diva.log no deskTopFile found 00f4:fixme:ntdll:NtQuerySystemInformation info_class SYSTEM_PERFORMANCE_INFORMATION Renoise LOG> VstPlugs: Analyzing VST plugin 'u-he: Diva(x64)', Unique ID:1147754081, Version:2400 Renoise LOG> VstPlugs: Instantiate OK Renoise LOG> VstWindow: Creating a new X11Window... Renoise LOG> VstWindow: Setting X11Window properties... Renoise LOG> VstWindow: Give the plug access to the X11Window... server 2 2 16 Renoise LOG> VstWindow: Query the X11Window child... Renoise LOG> VstWindow: Unexpected XGetWindowProperty ptr value: expected a userSize 32 with two entries, got userSize: 0 with 0 entries... Renoise LOG> VstWindow: Child window has no '_XEventProc' property set... Renoise LOG> VstWindow: Setting new Windowsize 1560, 870 Renoise LOG> VstWindow: Mapping the window... Renoise LOG> VstWindow: Setting new Windowsize 1560, 870 wine: Unhandled exception 0x80000003 in thread 138 at address 000000007BC54F00 (thread 0138), starting debugger... 0150:fixme:dbghelp:elf_search_auxv can't find symbol in module WARNING: RemotePluginServer::dispatchControlEvents: unexpected opcode 9999 0150:fixme:dbghelp:elf_search_auxv can't find symbol in module 0150:fixme:dbghelp:interpret_function_table_entry PUSH_MACHFRAME 15 ```Crash dialog
``` 0x000000007bc54f00 EntryPoint+0xffffffffffffffff in ntdll: int $3 Modules: Module Address Debug info Name (76 modules) PE 780000- 7a7000 Deferred aclui PE 61900000- 619b9000 Deferred sechost PE 62600000- 6271a000 Deferred usp10 PE 62b00000- 62c23000 Deferred advapi32 PE 64940000- 64992000 Deferred shcore PE 65000000- 65573000 Deferred ole32 PE 65780000- 6579f000 Deferred version PE 67600000- 67784000 Deferred combase PE 68a40000- 68b51000 Deferred shlwapi PE 6a700000- 6a8eb000 Deferred setupapi PE 6bec0000- 6bf23000 Deferred imm32 PE 6c0c0000- 6c0ed000 Deferred wsock32 PE 6e6c0000- 6ec1f000 Deferred comctl32 PE 6fbc0000- 6fe3d000 Deferred rpcrt4 PE 7b000000- 7b40b000 Deferred kernelbase ELF 7b600000- 7b867000 Deferred kernel32