osxmidi / LinVst

Linux Windows vst wrapper/bridge
GNU General Public License v3.0
682 stars 41 forks source link

Problem with AUR package in Manjaro /arch #193

Closed Lalarian closed 3 years ago

Lalarian commented 3 years ago

Hello! It seems you just changed the naming of your path from: https://github.com/osxmidi/LinVst/releases/download/4.5/LinVst-4.5-Manjaro.zip to https://github.com/osxmidi/LinVst/releases/download/4.5/LinVst-4.5.2-Manjaro.zip

This breaks compatibility with scripts like this: https://aur.archlinux.org/packages/linvst-bin It downloads the package using: source=( "$url/releases/download/$pkgver/LinVst-$pkgver-$suffix.zip") So I think the new scheme is hard to implant, because the url could arbitrarily change between the <major/minor> formatting and <major/minor/revision> all the time?

I wonder if the change was intended by reason, or if you just didn't know :)

osxmidi commented 3 years ago

Hello! It seems you just changed the naming of your path from: https://github.com/osxmidi/LinVst/releases/download/4.5/LinVst-4.5-Manjaro.zip to https://github.com/osxmidi/LinVst/releases/download/4.5/LinVst-4.5.2-Manjaro.zip

This breaks compatibility with scripts like this: https://aur.archlinux.org/packages/linvst-bin It downloads the package using: source=( "$url/releases/download/$pkgver/LinVst-$pkgver-$suffix.zip") So I think the new scheme is hard to implant, because the url could arbitrarily change between the <major/minor> formatting and <major/minor/revision> all the time?

I wonder if the change was intended by reason, or if you just didn't know :)

I try not to break the aur links, but in this case it was because of a bug in LinVst-4.5-Manjaro.zip.

What I'll do is rename LinVst-4.5.2-Manjaro.zip to LinVst-4.5-Manjaro.zip and put that up.

Lalarian commented 3 years ago

Thank you, very nice! :)

wolfsprite commented 3 years ago

Seems there may still be an issue here. :( Am also on Manjaro, tried to install LinVst today via package and got the following error:

: (1/1) Parsing SRCINFO: linvst-bin
==> Making package: linvst-bin 4.5-1 (Mon 02 Aug 2021 09:54:50 PM CDT)
==> Retrieving sources...
  -> Found LinVst-4.5-Manjaro.zip
==> Validating source files with md5sums...
    LinVst-4.5-Manjaro.zip ... FAILED
==> ERROR: One or more files did not pass the validity check!
error downloading sources: linvst-bin