osy / Polaris22Fixup

Metal driver patches for Vega M
MIT License
47 stars 7 forks source link

Fix the menu render issue in Big Sur 11.0.1 #11

Closed goodbest closed 3 years ago

goodbest commented 3 years ago

https://github.com/osy86/HaC-Mini/issues/316#issuecomment-731743555

The true explanation why the patch is working remains unknown yet, since 21 is a magical value in the dyld. The following is the logic why I try the number 0.

BTW, since I suppose a value between 0 and 21 would be better, I tried with different numbers for HVK. The patch is working with the patch if somevalue >=19, but no with somevalue >=20. However, I think it's still better to use if somevalue >=0 if there's no obvious side effect.

image image

This PR will close https://github.com/osy86/Polaris22Fixup/issues/10 https://github.com/osy86/HaC-Mini/issues/316

Potentially close: https://github.com/osy86/HaC-Mini/issues/392

keatliang2005 commented 3 years ago

I wonder the VRAM usage is about the same ? I didn't run any 3D APP, just chrome with youtube. that's it

Screenshot 2020-11-23 at 8 15 37 PM

goodbest commented 3 years ago

This may be a system issue, not related to the patch.

For the record, I'm using the kext all the time. Before 20:19, the VRAM is 99% but I did nothing other than Chrome.

After 20:19, I reboot the device, and start playing StarCraft2 (with metal engine). The VRAM remains ~30%, but the GPU processor reaches 99%(which means the game uses a lot calculations)

VRAM: image

GPU Processors image

osy commented 3 years ago

Cool, can you confirm that Metal isn’t disabled? By running a Geekbench Metal compute?

EDIT: ah didn’t see the comment in the other thread. Seems like you’ve already tried it.

keatliang2005 commented 3 years ago

@osy86 , @goodbest

I have run the Geekbench 5 test, looks good

Screenshot 2020-11-25 at 12 14 51 PM

osy commented 3 years ago

Thanks, I’ll include this in the next release.

davidwuya commented 3 years ago

My VRAM usage is also topping up when I use Chrome. Might be a bug, but haven't noticed any side effects yet. image