osyo-manga / unite-quickfix

29 stars 4 forks source link

Improve highlighting and wrapping #11

Closed petobens closed 10 years ago

petobens commented 10 years ago

Consider the following output of echo getqflist():

[{'lnum': 650, 'bufnr': 5, 'col': 0, 'valid': 1, 'vcol': 0, 'nr': -1, 'type': 'E', 'pattern': '', 'text': 'Undefined control sequence'}, {'lnum': 0, 'bufnr': 9, 'col': 0, 'valid': 1, 'vcol': 0, 'nr': -1, 'type': 'W', 'pattern': '', 'text': 'LaTeX Warning: Label(s) may have changed. Rerun to get cross-references right.'}, {'lnum': 0, 'bufnr': 9, 'col': 0, 'valid': 1, 'vcol': 0, 'nr': -1, 'type': 'W', 'pattern': '', 'text': 'Package biblatex Warning: Please rerun LaTeX.
                Page breaks have changed.'}, {'lnum': 0, 'bufnr': 9, 'col': 0, 'valid': 1, 'vcol': 0, 'nr': -1, 'type': 'W', 'pattern': '', 'text': 'pdfTeX warning: \pdfdraftmode enabled, not changing output pdf'}]

And compare the highlighting and the wrapping of the standard quickfix and unite-quickfix: i) why is it that unite-quickfix doesn't highlight the file name ("notas_tdm.tex") in yellow color when a warning doesn't have a line number? ii) why does unite-quick break the line Package Biblatex Warning:... Page breaks have changed.?

screenshot 160

osyo-manga commented 10 years ago

i) why is it that unite-quickfix doesn't highlight the file in yellow when a warning doesn't have a line number?

I have improved the highlights now.

ii) why does unite-quick break the line Package Biblatex Warning:... Page breaks have changed.?

Hmmm...did not reproduce it's my environment.

petobens commented 10 years ago

I have improved the highlights now.

This means that file before |warning| (for instance in your case unite.vim) gets highlighted?

Hmmm...did not reproduce it's my environment.

Maybe this is because the characters ^@ are added in my environment?

osyo-manga commented 10 years ago

I fixed highlighting and error message in ^@.

petobens commented 10 years ago

Thank you!!!!!!

osyo-manga commented 10 years ago

OK, thank for issues :)