osyrisrblx / t

A Runtime Typechecker for Roblox
MIT License
210 stars 39 forks source link

Replace usage of nonexistant `Enum.EnumType` #106

Closed Agapurnis closed 1 year ago

Agapurnis commented 2 years ago

I could be wrong about this, but I don't believe Enum.EnumType is currently defined anywhere within the RobloxTS typings as seen in the search results or the enums definition file. It may have existed before, but I don't see it now.

As such, I've removed it and replaced it with what I believe should achieve what the desired functionality was.

This approach picks out all the EnumItem properties so it's more future-proof in-case more methods are added, but if you wanted to stay consistent the approach of specifically excluding GetEnumItems could also be taken as it is done here.

Alternatively, this approach could always be applied there! 😉 The Enum.EnumType type could also potentially just be re-added. The generic should still probably be constrained to an Enum though, not { Name: string }.


EDIT: It I can confirm it was indeed removed based on commit 2c294fdc82df58c2c6bd031a432e9b15ef75d900 to @rbxts/roact.