ot4i / ace-docker

73 stars 167 forks source link

Define length limits on signal channels #165

Closed andyedwardsibm closed 3 years ago

andyedwardsibm commented 3 years ago

Relevant issue, Epic or stories.

https://github.com/ot4i/ace-docker/issues/164

Description of what this PR accomplishes and why it's needed

A recent update to golang means that it now fails to lint/compile when the os.Signal channel is used without a buffer length limit. We aren't signal-heavy and should only see one each of SIGTERM/SIGKILL so a short buffer length should suffice

How Has This Been Tested?

Have seen this build break in our internal builds, and seen this change resolve the build failure