Example `@sap/eslint-plugin-cds` does not work.

[ota-meshi]

It has probably been migrated to a flat configuration, but the examples have not been updated.

Reproduce Link: https://eslint-online-playground.netlify.app/#@sap/eslint-plugin-cds

[ota-meshi]

Hi @mnkiefer 👋 If you're interested, could you open a PR?

I'm in the process of migrating some plugins to a flat config. https://eslint-online-playground.netlify.app/#eslint-plugin-n

[mnkiefer]

Hi Mara Nikola Kiefer 👋 If you're interested, could you open a PR?

I'm in the process of migrating some plugins to a flat config. https://eslint-online-playground.netlify.app/#eslint-plugin-n

@ota-meshi: Thanks for reaching out! :heart: I recently changed jobs so I'm passing this onto the new maintainers of CDS lint.

@chgeo: Can you take this from here please? 🙏

[chgeo]

Reproduce Link: https://eslint-online-playground.netlify.app/#@sap/eslint-plugin-cds

I guess the sample code is stored here? https://github.com/ota-meshi/eslint-online-playground/tree/main/src/examples/plugin-eslint-plugin

@bugwelle @daogrady Can someone take this?

Note: In our documentation, we have already migrated our examples to flat config, see e.g. this one.

[chgeo]

@ota-meshi Bonus problem: the playground seems to be broken atm, as the source code editor cannot be loaded due to 404 from https://cdnjs.cloudflare.com/ajax/libs/monaco-editor/0.50.0/min/vs/loader.min.js

[ota-meshi]

@mnkiefer Wow! I wish you the best of luck in your new job ❤️

@chgeo Thank you for letting me know! I reverted monaco-editor to 0.49. #84

[ota-meshi]

I guess the sample code is stored here? https://github.com/ota-meshi/eslint-online-playground/tree/main/src/examples/plugin-eslint-plugin

I recommend you to refer to the following directory:

https://github.com/ota-meshi/eslint-online-playground/tree/main/src/examples/plugin-n

[ota-meshi]

Oh, I just realized that the plugin installer doesn't work either.

If you want it to work, could you also fix the following file?

https://github.com/ota-meshi/eslint-online-playground/blob/main/src/plugins/plugins/cds/plugin.ts

I think the following file will be helpful:

https://github.com/ota-meshi/eslint-online-playground/tree/main/src/plugins/plugins/n/plugin.ts

[ota-meshi]

@chgeo

@bugwelle @daogrady Can someone take this?

If it is difficult to maintain, we can also remove the code related to @sap/eslint-plugin-cds from this repository. As you already know, you can also use the playground by using a link with a hash 😉

[chgeo]

If it is difficult to maintain, we can also remove the code related to @sap/eslint-plugin-cds from this repository. As you already know, you can also use the playground by using a link with a hash 😉

Good point. It's not hard to maintain, but yet another code location that we need to be aware of. So what about removing the sample code here, but provide a link to our documentation page with more examples for the playground?

[ota-meshi]

Either is fine with me :wink: Personally, I'd like to see more use cases for the plugin in the playground, but I don't use @sap/eslint-plugin-cds, so I can't maintain it :sweat: If maintaining it becomes too costly for you, I think removing it from the playground is a good option.

[daogrady]

Hi everyone,

thanks for bringing this to our attention @ota-meshi. I will look into the issue and fix it asap to get this back into a working state and we can then discuss how to continue from there.

Best, Daniel