search

ota-meshi / eslint-plugin-regexp

ESLint plugin for finding regex mistakes and style guide violations.
https://ota-meshi.github.io/eslint-plugin-regexp/
MIT License
699 stars 10 forks source link

Prepare for v2 release. #649

Closed ota-meshi closed 1 year ago

ota-meshi commented 1 year ago

I think we are ready to release v2. However, just to be sure, I would like to check to see if there is really any remaining work.

ota-meshi commented 1 year ago

I think we need to replace jsdoctypeparser with jsdoc-type-pratt-parser. It seems that eslint-plugin-jsdoc was also replaced quite a while ago. https://www.npmjs.com/package/jsdoc-type-pratt-parser

ota-meshi commented 1 year ago

@RunDevelopment I noticed that no-super-linear-move is not included in the recommended config. I would like to include this in the recommended config, what do you think?

RunDevelopment commented 1 year ago

Are there any other rules that should be added to the recommended set?

Nope.

Are there any old ones to drop?

We have a few deprecated ones. We might as well remove them for good.

I noticed that no-super-linear-move is not included in the recommended config. I would like to include this in the recommended config, what do you think?

Not a good idea, unfortunately. The issue is that most cases of super linear moves simply cannot be fixed. You would need to switch to a different regex engine... This isn't an option most of the time, so I did not include the rule in recommended.

RunDevelopment commented 1 year ago

I guess we're in a pretty good spot to release v2.

But I would let it sit for a week or two and only release 2.0.0 then. Maybe there's still something we'll find.

ota-meshi commented 1 year ago

That's a good idea. I'll prerelease again and wait a week.

RunDevelopment commented 1 year ago

Alright, I think we're good to go.

I thought of 2 things that we could do to improve the new rules, but it turned out that we already did both of them, so that's good :) Now my only worry is that people might have trouble upgrading to 2.0.0, because we increased our requirements by a lot (nodejs, ESLint, Intl.Segement and Firefox). But this is an issue that will solve itself with time, so we probably don't have to worry about it.

So I think we're ready.

ota-meshi commented 1 year ago

I will release v2. If your project requires support for older ESLint or Nodejs, I think we can add support for them later. If so, please let me know.

ota-meshi commented 1 year ago

I just released v2 🎉 https://github.com/ota-meshi/eslint-plugin-regexp/releases/tag/v2.0.0