Limit suggestions to current locale, and export engine - Githubissues

ota-meshi / vuepress-plugin-full-text-search2

VuePress v2 plugin that adds full-text search box.

MIT License

34 stars 4 forks source link

Limit suggestions to current locale, and export engine #34

Open ctrueblood-epri opened 1 year ago

ctrueblood-epri commented 1 year ago

Thank you for developing vuepress-plugin-full-text-search2. I am proposing 2 changes in this pull request:

Return suggestions only for the current locale.
Export engine, which will allow useSuggestions to be imported in other components.

An additional suggestion (not in this pull request) is to define a new option:

suggestAllLocales (boolean)
When true, the search engine will return suggestions from all locales.
When false, the search engine will return suggestions only for the current locale.

Thank you for considering this request.

ota-meshi commented 1 year ago

Thank you for this PR. I'll check locale support when I have time. I think we need a new entry for export. For example, "./client" : "./lib/client/index.js".