sbrannen
commented
6 years ago Is this a reasonable solution (will it affect tooling),
Yes, this has the potential to affect tooling.
For example, Eclipse has built-in support for MultipleFailuresError. So if you override getMessage(), I can only assume that the Eclipse "Result Comparison" dialog will no longer work properly.
Though, to be honest, I don't know the details of how the "Result Comparison" feature in Eclipse is implemented. So you'd want to investigate that.
Other IDEs and reporting tools might depend on the built-in format for the failure message as well.
or is there a strong reason to go with the default message?
See above for reasons you would want to stay with the default message format.
Whether or not you override getMessage() really depends on your use case, your target audience, and what it is you hope to achieve.
In light of that, I am closing this issue since it is more of a question than an issue.
BenWoodworth
Hey, I'm looking at integrating opentest4j in my assertions lib. We already have a way we are formatting multiple errors. My current solution is to subclass
MultipleFailuresErrorand overridegetMessage(). Is this a reasonable solution (will it affect tooling), or is there a strong reason to go with the default message?