search

ota4j-team / opentest4j

Open Test Alliance for the JVM
Apache License 2.0
279 stars 37 forks source link

[WIP] Add explicit module descriptor #51

Closed sormuras closed 5 years ago

sormuras commented 5 years ago

Overview

Add explicit module descriptor module-info.class to META-INF/versions/9 -- generating a multi-release jar.

AnimalSniffer is "turned off" due to not working on with JDK 9+.

Spotless version is fixed, as upgrading it to 2.4.1 leads to many Javadoc-related violations.

I hereby agree to the terms of the Open Test Alliance Contributor License Agreement.

leonard84 commented 5 years ago

Do we really want to forgo the enforcement provided by animal-sniffer and spotless?

sormuras commented 5 years ago

It's only temporary. AnimalSniffer can replaced by the --release option of javac 9+ and Spotless complains about not being able to process module-info.java files. And... the current files are not complying the formatting style of the project, anyway.

jbduncan commented 5 years ago

Spotless complains about not being able to process module-info.java files

...So telling Spotless to skip module-info.java should fix things or at least allow us to move forward, right?

sormuras commented 5 years ago

...and not upgrading to Spotless 2.4.1:

Violations also present in:
    src\main\java\org\opentest4j\IncompleteExecutionException.java
    src\main\java\org\opentest4j\MultipleFailuresError.java
    src\main\java\org\opentest4j\package-info.java
    src\main\java\org\opentest4j\TestAbortedException.java
    src\main\java\org\opentest4j\TestSkippedException.java
    src\main\java\org\opentest4j\ValueWrapper.java
Run 'gradlew spotlessApply' to fix these violations.