"Finish map" dialog is invisble in fullscreen when embedded

fnoks commented 7 months ago

How to reproduce:

Embed a Game Map through the iframe embed code
Open it in fullscreen
Finish it

You'll notice the "Finish Map" dialog is not visible, but it will become visible when leaving fullscreen.

otacke commented 7 months ago

Thanks! I'll check that later today.

otacke commented 7 months ago

@fnoks There's a bug. I can reproduce the behavior.

I think the bug is in H5P core though. It happens with any H5P content that uses the H5P.ConfirmationDialog class when in fullscreen mode. Cmp. e.g.

Course Presentation: https://otacke.h5p.com/content/1292120357340996547/embed
Interactive Book: https://otacke.h5p.com/content/1292120361517939377/embed

Consistent in Chrome, Firefox and Safari. Quite consistent on different H5P integrations, too, including H5P.com, but not including moodle's custom H5P integration.

I created https://h5ptechnology.atlassian.net/browse/HFP-3824

otacke commented 7 months ago

Seems like there's a problem in GameMap and some other H5P component as well, potentially H5P Question that's used by H5P.MultiChoice for the confirmation dialog.

Fixed by https://github.com/otacke/h5p-game-map/pull/53

otacke / h5p-game-map

"Finish map" dialog is invisble in fullscreen when embedded #51