search

otacke / h5p-sharing

Make sharing H5P content even easier
MIT License
3 stars 1 forks source link

QR code pointer #2

Open larsaam opened 4 months ago

larsaam commented 4 months ago

Thank you for a very nice plugin.

A problem is that the QR code point to the embeded code and not the direct link.

Use case:

The QR code is perfect to share with participants in a course.

Thank you

otacke commented 4 months ago

@larsaam What "direct link" are you referring to? If you need some configurable URL, e. g. to enter a custom URL of some other page, you could use any other QR code generator.

larsaam commented 4 months ago

In the plugin you have a Direct link and a QR code.

But the QR code is not pointing to the direct link as expected..

Screenshot from 2024-03-11 08-55-02

otacke commented 4 months ago

@larsaam If the QR code also links to the embed code, then everything works as expected and according to the requirements that this plugin was built for.

larsaam commented 4 months ago

@otacke It only points to the embeded code..

otacke commented 4 months ago

@larsaam As I said, that's what it is supposed to do and meets the requirements that this plugin was developed for.

larsaam commented 4 months ago

@otacke Why are the QR code for the embeded link not in the embeded section, but inthe direct link section?

I really do not understand why anyone would need a QR code for an embedding link?

otacke commented 4 months ago

@larsaam You would have to ask the original initiator why they wanted it that way. Again: This works as it was supposed to.

I am not actively developing this plugin (that's why you don't find it on the WordPress plugin page). I merely saved it from getting purged when the organization that wanted to have it ceased existing. If you want to use it, please do. If it doesn't fit your use case, then I am sorry, but I am not going to spend any free time on it. If you want to change it, please feel free to - that's what open source code is for. And if you even want to maintain it, I'll gladly transfer the repository to you.

larsaam commented 4 months ago

@otacke It is even in the description

"When viewing H5P content in the editor, have a QR Code to directly link to the content."

So the plugin does not work as it is supposed to. If you could have said you do not care initially it would have spared both you and me the arguing time..

otacke commented 4 months ago

@larsaam When you open the QR code link, will you be taken directly to the H5P content? Yes. You do. And I am really repeating myself now: This works just like the organization that let me build this wanted it to be. So this is working as it is supposed to.

Is this being what you expect or would want? No, obviously not. But, again, as I already said: Please change the code the way you need it. That's what open source is for.