otalk / rtcpeerconnection-shim

Implementation of the RTCPeerConnection API ontop of ORTC
BSD 3-Clause "New" or "Revised" License
15 stars 14 forks source link

use property descriptors for .localDescription and .remoteDescription #141

Closed fippo closed 6 years ago

fippo commented 6 years ago

to make this overridable in rtcpeerconnection-jingle

also do the same for other properties while i'm at it

codecov-io commented 6 years ago

Codecov Report

Merging #141 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #141      +/-   ##
=========================================
+ Coverage    99.8%   99.8%   +<.01%     
=========================================
  Files           8       8              
  Lines        1030    1033       +3     
=========================================
+ Hits         1028    1031       +3     
  Misses          2       2
Impacted Files Coverage Δ
rtcpeerconnection.js 99.73% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 340c349...755ada6. Read the comment docs.

fippo commented 6 years ago

backporting to 1.2.11 and publishing a bugfix version 1.2.12

fippo commented 6 years ago

this should probably also be done for some other properties:

    this.canTrickleIceCandidates = null;
    this.signalingState = 'stable';
    this.iceConnectionState = 'new';
    this.connectionState = 'new';
    this.iceGatheringState = 'new';

and also currentLocalDescription and friends.