otalk / rtcpeerconnection-shim

Implementation of the RTCPeerConnection API ontop of ORTC
BSD 3-Clause "New" or "Revised" License
15 stars 14 forks source link

signalingstatechange is emitted even if there are no updates #142

Closed fippo closed 6 years ago

fippo commented 6 years ago
    it('does stuff', () => {
      const sdp = SDP_BOILERPLATE +
          MINIMAL_AUDIO_MLINE;
      pc.onsignalingstatechange = () => console.log('here');
      return pc.setRemoteDescription({type: 'offer', sdp})
      .then(() => pc.setRemoteDescription({type: 'offer', sdp}));
    });

logs 'here' twice. It should not since the spec says

10. If connection's signaling state changed above, fire a simple event named
 signalingstatechange at connection.

https://w3c.github.io/webrtc-pc/#set-the-rtcsessiondescription

syerrapragada commented 6 years ago

Is there an ETA for the next release? There are many fixes and improvements I see already committed to the branch.

fippo commented 6 years ago

The next release is going to be a major version bump due to the size of changes. Current ETA is sometime in October