search

otalk / rtcpeerconnection-shim

Implementation of the RTCPeerConnection API ontop of ORTC
BSD 3-Clause "New" or "Revised" License
15 stars 14 forks source link

Missing a=ice-options attribute in answer sdp #155

Closed syerrapragada closed 6 years ago

syerrapragada commented 6 years ago

createAnswer doesn't set a=ice-options:trickle in the sdp.

fippo commented 6 years ago

right, see http://rtcweb-wg.github.io/jsep/#rfc.section.5.3.1

 except that the "a=ice-options" line, with the "trickle" option as specified in
[I-D.ietf-ice-trickle], Section 4, is only included if such an option was 
present in the offer.

Now I wonder if the list of options is declaritive or a subset of the offer...

syerrapragada commented 6 years ago

@fippo For this issue is following a potential solution?

Adding following check at https://github.com/otalk/rtcpeerconnection-shim/blob/master/rtcpeerconnection.js#L1324

if(pc._canTrickleIceCandidates) {
  sdp += 'a=ice-options:trickle\r\n';
}
fippo commented 6 years ago

it looks like ice-options is declarative, see discussion in https://mozilla.logbot.info/media/20180905#c15270769

i'll have a patch shortly.

fippo commented 6 years ago

cherry-picked into the 1.2.14 patch release