search

otalk / rtcpeerconnection-shim

Implementation of the RTCPeerConnection API ontop of ORTC
BSD 3-Clause "New" or "Revised" License
15 stars 14 forks source link

Fix media section sdp for rejected datachannels #170

Closed syerrapragada closed 5 years ago

syerrapragada commented 5 years ago

@fippo Attempt to fix #166

codecov-io commented 5 years ago

Codecov Report

Merging #170 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
+ Coverage   99.81%   99.81%   +<.01%     
==========================================
  Files           8        8              
  Lines        1072     1086      +14     
==========================================
+ Hits         1070     1084      +14     
  Misses          2        2
Impacted Files Coverage Δ
rtcpeerconnection.js 99.74% <100%> (ø) :arrow_up:
writemediasection.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f37cd0b...e7a9df6. Read the comment docs.

syerrapragada commented 5 years ago

@fippo Thanks for the review. I will address them soon.

fippo commented 5 years ago

LGTM, sorry for the long delay. Do you want to squash or shall I?

Planning to publish a 2.0.0 with this under the "next" tag. Not sure whether its even worth the effort of QA-ing a major release before Edge switches to Chrome...

syerrapragada commented 5 years ago

I dont have permissions to merge. @fippo Could you please squash merge?

fippo commented 5 years ago

2.0.0 published on the "next" tag