wrong treatment of video-audio offers

otalk / rtcpeerconnection-shim

Implementation of the RTCPeerConnection API ontop of ORTC

BSD 3-Clause "New" or "Revised" License

15 stars 14 forks source link

wrong treatment of video-audio offers #183

Open fippo opened 5 years ago

fippo commented 5 years ago

reported by @dagingaa. If you call addTrack(audioTrack), addTrack(videoTrack) and then set an offer containing a video mline followed by an audio mline the answer will be wrong. This happens with offers from safari, other browsers Fiddle with repro data: https://jsfiddle.net/mu6kcxrw/1/

There is a test for a similar issue here ('keeps the order from the remote offer') but it did not catch this behaviour, possibly due to the assertion being too weak.

fippo commented 5 years ago

seems fixed in master (future-but-will-never-happen-2.x) but not the 1.x version adapter uses :-|