search

otalk / sdp

SDP parsing and serialization utlities
MIT License
46 stars 11 forks source link

writeRtcpFeedback: allow empty parameter #2

Closed fippo closed 8 years ago

fippo commented 8 years ago 
                {
                    payloadType: 100,
                    name: 'VP8',
                    clockRate: 90000,
                    numChannels: 1,
                    parameters: {},
                    rtcpFeedback: [
                        {
                            type: 'ccm',
                            parameter: 'fir'
                        },
                        {
                            type: 'nack'
                        },
                        {
                            type: 'nack',
                            parameter: 'pli'
                        },
                        {
                            type: 'goog-remb'
                        }
                    ]
                }

Currently doesn't serialize well

fippo commented 8 years ago

can't repro (turned out to be old version) but now there is a test