armouroflight commented 7 years ago

This change should generally be compatible with previous versions. It's just adjusts the session IDs since some code expects the SDP to use a specific session ID (used in adapter.js).

codecov-io commented 7 years ago

Codecov Report

Merging #31 into master will increase coverage by 0.17%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   90.14%   90.31%   +0.17%     
==========================================
  Files           1        1              
  Lines         284      289       +5     
==========================================
+ Hits          256      261       +5     
  Misses         28       28

Impacted Files	Coverage Δ
sdp.js	`90.31% <100%> (+0.17%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 46b6885...2fb3b42. Read the comment docs.

fippo commented 7 years ago

Are you ok with contributing it under the terms of https://developercertificate.org/ (I need to update the contributing file)?

Two minor comments inline, I can take care of them after merging.

armouroflight commented 7 years ago

I am happy with contributing under those terms. Thanks!

fippo commented 7 years ago

Fab, thank you very much.

Sadly I forgot to hit the "submit review button". Will fix those issues after merging later today unless you beat me to it

armouroflight commented 7 years ago

I've updated the comments as suggested - makes sense.

fippo commented 7 years ago

squashed, merged and published as version 2.1.0

otalk / sdp

Add session ID generation #31

Codecov Report