search

otalk / sdp

SDP parsing and serialization utlities
MIT License
46 stars 11 forks source link

writeBoilerPlate: write session version #32

Closed fippo closed 7 years ago

fippo commented 7 years ago

also writes the session version.

@armouroflight I mostly made it so i can do a proper "session id remains constant but sess-ver increases" test ;-)

codecov-io commented 7 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9030bc0). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #32   +/-   ##
=========================================
  Coverage          ?   90.34%           
=========================================
  Files             ?        1           
  Lines             ?      290           
  Branches          ?        0           
=========================================
  Hits              ?      262           
  Misses            ?       28           
  Partials          ?        0
Impacted Files Coverage Δ
sdp.js 90.34% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9030bc0...037733c. Read the comment docs.

fippo commented 7 years ago

sigh looks like codecov doesn't like when people use the squash + merge button (or this is because the other commit did not run through CI) :-/