search

otalk / sdp

SDP parsing and serialization utlities
MIT License
46 stars 11 forks source link

writeIceParameters: add iceLite #41

Closed fippo closed 4 years ago

fippo commented 6 years ago

from http://draft.ortc.org/#dom-rtciceparameters

breaking change imo

codecov-io commented 6 years ago

Codecov Report

Merging #41 into master will increase coverage by 0.08%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   91.26%   91.34%   +0.08%     
==========================================
  Files           1        1              
  Lines         309      312       +3     
==========================================
+ Hits          282      285       +3     
  Misses         27       27
Impacted Files Coverage Δ
sdp.js 91.34% <100%> (+0.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3e09c82...90b21df. Read the comment docs.

fippo commented 6 years ago

should probably write ice-options too

fippo commented 6 years ago

note that ice-lite is a session-level parameter in SDP and writing it at media level is accepted by Chrome but not Firefox

fippo commented 4 years ago

:cherries:-picked into the v3 branch