codecov-io commented 5 years ago

Codecov Report

Merging #57 into master will decrease coverage by 3.17%. The diff coverage is 14.28%.

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
- Coverage   91.76%   88.59%   -3.18%     
==========================================
  Files           1        1              
  Lines         328      342      +14     
==========================================
+ Hits          301      303       +2     
- Misses         27       39      +12

Impacted Files	Coverage Δ
sdp.js	`88.59% <14.28%> (-3.18%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 79d3114...5743ef6. Read the comment docs.

fippo commented 4 years ago

sadly I think its a bit more complicated, see

   a=rid:1 send pt=97;max-width=1280;max-height=720
   a=rid:2 send pt=98;max-width=320;max-height=180
   a=rid:3 send pt=99;max-width=320;max-height=180
   a=rid:4 recv pt=97
   a=simulcast:send 1;2,3 recv 4

from https://tools.ietf.org/html/draft-ietf-mmusic-sdp-simulcast-14

benbro commented 4 years ago

I'm missing pt, max_width and max_height? How the json should look?

fippo commented 4 years ago

that is a very good question. We don't have those in the spec either: https://w3c.github.io/webrtc-pc/#dom-rtcrtpcodingparameters

otalk / sdp

Parse and write simulcast encodings #57

Codecov Report