search

otalk / sdp

SDP parsing and serialization utlities
MIT License
46 stars 11 forks source link

Add a=rtcp-rsize to the rtp description #61

Closed benbro closed 4 years ago

benbro commented 5 years ago

rtcpParameters.reducedSize is set in parseRtcpParameters but rtcpParameters isn't used in writeRtpDescription Chrome only add rtcp-rsize to video m-section but I don't think it will be a problem to always include it. Alternativly we could pass rtcpParameters to writeRtpDescription or add rtcp-rsize toSDP

codecov-io commented 5 years ago

Codecov Report

Merging #61 into master will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #61      +/-   ##
=========================================
+ Coverage   92.28%   92.3%   +0.02%     
=========================================
  Files           1       1              
  Lines         350     351       +1     
=========================================
+ Hits          323     324       +1     
  Misses         27      27
Impacted Files Coverage Δ
sdp.js 92.3% <100%> (+0.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1944fc3...9adc356. Read the comment docs.

fippo commented 4 years ago

this is rtcp, not rtp, see #46 . v3 (#70) will feature a writeRtcpDescription

benbro commented 4 years ago

Thanks