search

otavepto / gbe_fork

Fork of https://gitlab.com/Mr_Goldberg/goldberg_emulator
https://gitlab.com/Mr_Goldberg/goldberg_emulator
GNU Lesser General Public License v3.0
191 stars 55 forks source link

fix Stellaris multiplayer #103

Closed detiam closed 3 months ago

detiam commented 3 months ago

according to https://gitlab.com/Mr_Goldberg/goldberg_emulator/-/issues/190#note_1045545523

otavepto commented 3 months ago

This might break other games, the docs (which are not always accurate) specify that 0 is a valid index: https://partner.steamgames.com/doc/api/ISteamMatchmakingServers#GetServerDetails

Did you test that change ? Just asking because you specified the original change as a source.

detiam commented 3 months ago

This might break other games, the docs (which are not always accurate) specify that 0 is a valid index: https://partner.steamgames.com/doc/api/ISteamMatchmakingServers#GetServerDetails

Did you test that change ? Just asking because you specified the original change as a source.

Tested with friend, not test if we have two rooms, this pr is broken, sorry. Find out this https://github.com/otavepto/gbe_fork/commit/3d836d694dbc6be28666d3d131120b7fa5249460 and prior commit already resolved the problem, I just need to create matchmaking_server_list_actual_type.txt in steam_settings, thank you!