search

otavepto / gbe_fork

Fork of https://gitlab.com/Mr_Goldberg/goldberg_emulator
https://gitlab.com/Mr_Goldberg/goldberg_emulator
GNU Lesser General Public License v3.0
191 stars 55 forks source link

Players not show in overlay after some emu updates #107

Closed Vlxst closed 3 months ago

Vlxst commented 3 months ago

well, the other players stopped appearing in the overlay after the release: https://github.com/otavepto/gbe_fork/releases/tag/release-2024_2_29 (Latest release that works) I can even send an invitation internally through the game, but nothing is shown either. release-2024_229 works correctly, no other release after this is working only one player can be seen on the overlay everything seems to work fine (inviting and joining the lobby) but it is not possible to do this for those players that do not appear in the overlay (there is no configuration conflict, see screenshot) I tested all the releases mentioned_ including in several games

thanks again for you work! image

otavepto commented 3 months ago

Test the build artifact from the linked PR, use the debug build please to share the logs.

Vlxst commented 3 months ago

Test the build artifact from the linked PR, use the debug build please to share the logs.

I will test it now

Vlxst commented 3 months ago

@otavepto image the PR Work, correctly shows players on the network. STEAM_LOG (Mr.V - Player1).txt STEAM_LOG (Vivi - Player2).txt

otavepto commented 3 months ago

Thanks for testing it, I'll merge this PR then.

Vlxst commented 3 months ago

Thanks for testing it, I'll merge this PR then.

I thank you again❤ Out of curiosity, what was the problem?

otavepto commented 3 months ago

During the emu startup it will try to discover people on the same network, this happens very early on during game initialization, and it seems to happen only once or very rarely. https://github.com/otavepto/gbe_fork/blob/ac951f1a7d9f6a984a5716bab6bfd0a14a7d11ac/dll/dll/steam_friends.h#L1211-L1218

But the overlay takes some time to initialize, and in one of the recent changes I made it completely ignore all outside requests/calls if it wasn't initialized yet. https://github.com/otavepto/gbe_fork/blob/ac951f1a7d9f6a984a5716bab6bfd0a14a7d11ac/overlay_experimental/steam_overlay.cpp#L1836-L1841

So it was ignoring connections from new friends/players during startup. You can use the release build from the same PR now.

Vlxst commented 3 months ago

you are the best! thanks again.