Change overlay font to Unifont and allow load custom TTF font

otavepto / gbe_fork

Fork of https://gitlab.com/Mr_Goldberg/goldberg_emulator

https://gitlab.com/Mr_Goldberg/goldberg_emulator

GNU Lesser General Public License v3.0

191 stars 55 forks source link

Change overlay font to Unifont and allow load custom TTF font #114

Closed detiam closed 3 months ago

detiam commented 3 months ago

overlay Resolve #99

Detanup01 commented 3 months ago

Looks good to me. Thanks!

otavepto commented 3 months ago

I left a review comment but when I viewed the PR as a guest it wasn't even visible. Normally it's displayed here, if you open the Files changed tab you can find it. How should I do it properly so that they appear here ?

otavepto commented 3 months ago

Really Github ?! apparently after commenting you have to scroll up, then press Submit review 😭 Just for the record, I left this comment 2 days ago, I didn't just ignore this PR, but I'm an idiot obviously 👍

detiam commented 3 months ago

Added an option for load custom TTF font :p

otavepto commented 3 months ago

Thank you. Will push a release later today

otavepto commented 3 months ago

Because of the observation @detiam made regarding the merge mode, I wanted to try out what it would've looked like with the old set of fonts when the default/builtin font isn't loaded

Had I had at least 1% competence, everybody would've been happy including myself.