otavepto / gbe_fork

Fork of https://gitlab.com/Mr_Goldberg/goldberg_emulator
https://gitlab.com/Mr_Goldberg/goldberg_emulator
GNU Lesser General Public License v3.0
191 stars 55 forks source link

Small lobby_connect redesing #126

Closed M4RCK5 closed 2 months ago

M4RCK5 commented 2 months ago

Can u please remove these 2 lines at the start of the tool:

This is a program to find lobbies and run the game with lobby connect parameters Api initialized,

Just leave:

Waiting for connections:

And make it clear the window on retry? It's just to not flood the window so it looks better when trying to launch it from a script. Had to start using it because on some machines the overlay makes the game crash at launch.

otavepto commented 2 months ago

Ahhh, I can't make specialized changes for specific use cases. I'd encourage you to fork the repo and make these changes for your use case. I've set it up so that Github can build everything for you. You can actually do everything from the browser.

These are the lines you can remove https://github.com/otavepto/gbe_fork/blob/ca8fb4bc358f2e726715c5796fdbedebe28cd2d9/tools/lobby_connect/lobby_connect.cpp#L40-L41

Follow this guide on the front readme for the steps https://github.com/otavepto/gbe_fork?tab=readme-ov-file#using-github-ci-as-a-builder https://github.com/otavepto/gbe_fork?tab=readme-ov-file#manual-trigger

In short, fork the repo, set the proper permissions for the Github Actions, and finally press Run on the corresponding workflow! It's really that easy, I sometimes do that out of laziness.

M4RCK5 commented 2 months ago

Solved, please close this issue, thanks for ur help.