otavepto / gbe_fork

Fork of https://gitlab.com/Mr_Goldberg/goldberg_emulator
https://gitlab.com/Mr_Goldberg/goldberg_emulator
GNU Lesser General Public License v3.0
191 stars 55 forks source link

Witcher 3 Overlay Crash #130

Closed Plades closed 2 months ago

Plades commented 2 months ago

I open Witcher 3 with overlay_hook_delay_sec.txt set, the game runs fine but crashes when I want to exit the game. STEAM_LOG.txt

otavepto commented 2 months ago

Nothing weird in the logs, the game even called SteamAPI_UnregisterCallback() after removing the overlay, meaning it was running fine. I can't do anything really. At least it happens on exit, if it's really bothering you just disable it and use Achievement Watcher + lobby_connect.exe as replacement tools, it's a highly experimental feature that honestly brought more trouble than good.

Vlxst commented 2 months ago

Nothing weird in the logs, the game even called SteamAPI_UnregisterCallback() after removing the overlay, meaning it was running fine. I can't do anything really. At least it happens on exit, if it's really bothering you just disable it and use Achievement Watcher + lobby_connect.exe as replacement tools, it's a highly experimental feature that honestly brought more trouble than good.

Wouldn't there be another way to hook the overlay? It seems like the way it works has changed a lot. A way to make her compatible. Especially because if it's a game that uses overlay to invite,Disabling will make emu unusable for invites

otavepto commented 2 months ago

I alrady aswered this, invitations could be handled by lobby connect, the code in the overlay was copy/pasted from the lobby connect tool.

Also answered your question in the other issue, no there's nothing that could be done. The hooking isn't done by the emu, by the ingame overlay project, which is a third party library integrated in the emu. An analogy If you found a problem with google protobuf or zlib or curl, would you expect it to be solved here?

And yes, the way it works has changed a lot, because it was updated.

It's crashing on exit, why is this such a big problem for you