otavepto / gbe_fork

Fork of https://gitlab.com/Mr_Goldberg/goldberg_emulator
https://gitlab.com/Mr_Goldberg/goldberg_emulator
GNU Lesser General Public License v3.0
185 stars 54 forks source link

Ticket error fix if returned is bigger then the Maximum #145

Closed Detanup01 closed 2 months ago

Detanup01 commented 2 months ago

Since when I did it I forgot to actually allocate the space for it and #143 did a little bit of the thing that actually allocated less then we used so it caused crash

Detanup01 commented 2 months ago

should be better now

Detanup01 commented 2 months ago

Oh right, but how can I fix the other cpp issue ? :D

otavepto commented 2 months ago

Oh right, but how can I fix the other cpp issue ? :D

Oh sorry I linked the wrong line, it should be this one https://github.com/otavepto/gbe_fork/blob/29d973ad4b543ead484389667ea171359b9b6815/dll/auth.cpp#L130

If you're referring to the issue of pre-owned IDs, I already fixed it. Now this built-in list is separate from the user DLCs and even disabled by default.

Detanup01 commented 2 months ago

auth (192) and the other one (you can see what errors out in action) [Seems like I guess fixed it not sure]

Detanup01 commented 2 months ago

It build (and didnt failed). yey. Feel free to check and if good then you can merge

otavepto commented 2 months ago

Thank you