otavepto / gbe_fork

Fork of https://gitlab.com/Mr_Goldberg/goldberg_emulator
https://gitlab.com/Mr_Goldberg/goldberg_emulator
GNU Lesser General Public License v3.0
185 stars 54 forks source link

steam preowned ids should not contaminate user dlc list #146

Closed otavepto closed 2 months ago

otavepto commented 2 months ago

the builtin list is over ~700 ID, check for it separately and don't merge it with the user's list. also take care of installed app ids, don't merge with this list too. details starting from this comment: https://github.com/otavepto/gbe_fork/issues/143#issuecomment-2080666147

froggz19 commented 2 months ago

No rest for the wicked is actually crashing with this enabled.

otavepto commented 2 months ago

You can test the build artifact of the attached PR, I've changed this flag to be disabled bu default and the option is now called enable_steam_preowned_ids instead. See if enabling it now on purpose will crash the game, use the debug build so you can attach the debug log in case of a crash.

froggz19 commented 2 months ago

You can test the build artifact of the attached PR, I've changed this flag to be disabled bu default and the option is now called enable_steam_preowned_ids instead. See if enabling it now on purpose will crash the game, use the debug build so you can attach the debug log in case of a crash.

Not crashing anymore, nice.