otavepto / gbe_fork

Fork of https://gitlab.com/Mr_Goldberg/goldberg_emulator
https://gitlab.com/Mr_Goldberg/goldberg_emulator
GNU Lesser General Public License v3.0
185 stars 54 forks source link

Remove Startup Delay #162

Open jwood00 opened 1 month ago

jwood00 commented 1 month ago

Just a suggestion based on personal preference, but I would love to see an option to disable loading the overlay's achievement images at startup added to one of the .ini files. I have never experienced stuttering when unlocking achievements on older builds of the emulator, and I find the ~2 second delay at the start of DX12 games (it's not nearly as bad on DX11 games) to be rather annoying.

otavepto commented 1 month ago

Some notes, here's what that will do:

Basically, a regression in all aspects back to how it was previously, in favor of gaining literally around ~5 seconds of startup time. Just for the second reason alone (impacting gameplay) I'm tempted to reject this issue.

I'll leave it for now if someone else wants to add a flag for it, here's the relevant function https://github.com/otavepto/gbe_fork/blob/a844d85dd380d77b7936234c63e9942b34868ae5/overlay_experimental/steam_overlay.cpp#L377-L378

At the end of it, there's a flag which declares that this function has done it's job. I doesn't matter if the icons were loaded or not, it just needs to run once and loop over all achievements. https://github.com/otavepto/gbe_fork/blob/a844d85dd380d77b7936234c63e9942b34868ae5/overlay_experimental/steam_overlay.cpp#L407-L409

And that flag, impacts the overall state of the overlay https://github.com/otavepto/gbe_fork/blob/a844d85dd380d77b7936234c63e9942b34868ae5/overlay_experimental/steam_overlay.cpp#L1794-L1797