search

otavepto / gbe_fork

Fork of https://gitlab.com/Mr_Goldberg/goldberg_emulator
https://gitlab.com/Mr_Goldberg/goldberg_emulator
GNU Lesser General Public License v3.0
185 stars 54 forks source link

note on interface versions #169

Closed Detanup01 closed 1 month ago

Detanup01 commented 1 month ago

Check #161

otavepto commented 1 month ago

Thank you so much. This comment actually makes me worried a little

// Here we always use the STEAMSCREENSHOTS_INTERFACE_VERSION003 since 01-02 has small difference

The way compilers handle inheritance and vftables isn't really standardized, it might be better/safer to just add the actual interface to the inheritance list like the others. I don't know why Goldberg didn't add the interfaces if they're publicly available. I'll open a separate issue for that. If #161 is no longer relevant we can close it.

Just wanted to let you know you can always push to dev directly, I have absolutely no problem with that 👍

Detanup01 commented 1 month ago

about the dev push, because its protected I cannot push it via github.dev site

otavepto commented 1 month ago

the website should give you these options since I've added you to the rules bypass list image from terminal you'll be able to do this

git push --force

let me know if none of that works