otavepto / gbe_fork

Fork of https://gitlab.com/Mr_Goldberg/goldberg_emulator
https://gitlab.com/Mr_Goldberg/goldberg_emulator
GNU Lesser General Public License v3.0
185 stars 54 forks source link

steam screenshot #172

Closed Detanup01 closed 1 month ago

Detanup01 commented 1 month ago

Fixes #171

otavepto commented 1 month ago

Thanks a lot that was really fast, apparently I broke the workflows trigger, dammiiiiit I'll look into it

Detanup01 commented 1 month ago

wait nooo

Detanup01 commented 1 month ago

we got these two:

ScreenshotHandle AddScreenshotToLibrary( const char *pchFilename, const char *pchThumbnailFilename, int nWidth, int nHeight );

ScreenshotHandle AddScreenshotToLibrary( const char *pchJpegOrTGAFilename, const char *pchJpegOrTGAThumbFilename, int nWidth, int nHeight );

should be beoth can be there or only one?

otavepto commented 1 month ago

too late 😄 (just kidding, I'll revert it it's just a button click), you are right this has to be added, otherwise it won't compile.

Edit: apparently github doesn't allow it, you can just create a new PR on same branch

Detanup01 commented 1 month ago

ok now should work!

otavepto commented 1 month ago

we got these two:

ScreenshotHandle AddScreenshotToLibrary( const char *pchFilename, const char *pchThumbnailFilename, int nWidth, int nHeight );

ScreenshotHandle AddScreenshotToLibrary( const char *pchJpegOrTGAFilename, const char *pchJpegOrTGAThumbFilename, int nWidth, int nHeight );

should be beoth can be there or only one?

I forgot to actually respond to this!, the 2 functions have the same return type, same number of args, and each arg (from both interfaces) has same data type. The C++ compiler will consider both functions the same actually, this is what the compiler will see, notice the lack of params names

ScreenshotHandle AddScreenshotToLibrary( const char * , const char * , int , int );