otavepto / gbe_fork

Fork of https://gitlab.com/Mr_Goldberg/goldberg_emulator
https://gitlab.com/Mr_Goldberg/goldberg_emulator
GNU Lesser General Public License v3.0
183 stars 51 forks source link

fix the conditions for achievement progress indication #234

Closed otavepto closed 1 week ago

otavepto commented 1 week ago

fixes for both, the user achievements.json in the saves folder + the overlay tested on appid 1583230

I acknowledge this introduces a new warning (conversion from float to uint32) and I left it intentionally so we don't forget about it later. The original function Steam_User_Stats::IndicateAchievementProgress() works only with uint32, but it looks like some stats could be float, since there's no overload, I was lazy and didn't bother adding one :/

otavepto commented 1 week ago

I pushed more commits to complete/finalize this: