otavepto / gbe_fork

Fork of https://gitlab.com/Mr_Goldberg/goldberg_emulator
https://gitlab.com/Mr_Goldberg/goldberg_emulator
GNU Lesser General Public License v3.0
191 stars 55 forks source link

Fix utf-8 handling in different places + language comparison #243

Closed otavepto closed 3 days ago

otavepto commented 3 days ago

After many trials I came to the same conclusion as Goldberg and probably everyone else.

After 2-3 years I've re-discovered why Goldberg made the 2 functions utf8_encode and utf8_decode :/ There's actually no other way around this problem on Windows. Unicode encoding has a lot of bad history and compatibility problems, both in C++ runtime and in Win32 APIs. It is agonizing.

This PR fixes all of that + the original problem where the overlay language wasn't being changed:

Closes #239

otavepto commented 3 days ago

Here's also how the achievements look like when English is used as the emu language

image

And when Latam is used as the emu language

image

language=... must be changed in configs.user.ini