search

otavepto / gbe_fork

Fork of https://gitlab.com/Mr_Goldberg/goldberg_emulator
https://gitlab.com/Mr_Goldberg/goldberg_emulator
GNU Lesser General Public License v3.0
193 stars 56 forks source link

allow overlay notification sound when the overlay is not shown #56

Closed otavepto closed 2 months ago

otavepto commented 5 months ago

currently the audio is played when the overlay is not shown. requested in #17

Detanup01 commented 5 months ago

Like achievement? Invite sound or what?

otavepto commented 5 months ago

The achievement earned sound, it should be this function:

https://github.com/otavepto/gbe_fork/blob/7c1f7dc4ab2530041daa95453bd16ace92d9b9dc/overlay_experimental/steam_overlay.cpp#L355

I assume this condition is why it doesn't play the sound if the overlay is active/displayed on the screen

if (!show_overlay)
otavepto commented 2 months ago

done